add an asset for the Linux Android NDK.

add an asset for the Linux Android NDK.

I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003

Committed: https://skia.googlesource.com/skia/+/5580c6913500ccd80fb03a72e6992ee0d5b42d88

[mtklein_C, 2016-08-25 21:44:36]

Description was changed from

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py.

BUG=skia:
==========

to

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003
==========

[mtklein_C, 2016-08-25 21:46:52]

Description was changed from

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003
==========

to

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003
==========

[mtklein_C, 2016-08-25 21:47:04]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[borenet, 2016-08-26 11:29:02]

LGTM, but you probably want to include the VERSION file when it's written.

[mtklein_C, 2016-08-26 15:12:23]

On 2016/08/26 at 11:29:02, borenet wrote:
> LGTM, but you probably want to include the VERSION file when it's written.

Done.

[mtklein_C, 2016-08-26 15:12:28]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-26 15:12:28]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/2275093003/#ps20001
(title: "version")

[commit-bot: I haz the power, 2016-08-26 15:12:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-26 15:14:31]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-08-26 15:30:26]

PTAL @ PS 3.  This V2 is somewhat smaller now (737 MB on CIPD, 2.44GB on GS)
without the original zip.

[mtklein_C, 2016-08-26 15:58:05]

On 2016/08/26 at 15:30:26, mtklein_C wrote:
> PTAL @ PS 3.  This V2 is somewhat smaller now (737 MB on CIPD, 2.44GB on GS)
without the original zip.

And now, V3/PS4 is the same 737MB on CIPD but a svelte 729MB on GS after turning
on compression in zip_utils.py.

[mtklein_C, 2016-08-26 15:58:39]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:58:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-08-26 16:33:24]

LGTM, thanks!

[mtklein_C, 2016-08-26 16:35:37]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-08-26 16:35:38]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:35:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-26 16:41:07]

The CQ bit was unchecked by mtklein@google.com

[mtklein_C, 2016-08-26 17:03:03]

OK, one last version to look at, I promise.

v4 is the same as v3, with the top directory of the NDK stripped away.  This
makes it somewhat simpler to use from GN, as the path you pass to download.py is
now identical to the path you pass to GN, e.g.

$ python infra/bots/assets/android_ndk_linux/download.py -t /tmp/ndk
$ gn gen arm64 --args='ndk="/tmp/ndk" target_cpu="arm64"'

[borenet, 2016-08-26 17:08:15]

LGTM with suggestion.

https://codereview.chromium.org/2275093003/diff/80001/infra/bots/assets/andro...
File infra/bots/assets/android_ndk_linux/create.py (right):

https://codereview.chromium.org/2275093003/diff/80001/infra/bots/assets/andro...
infra/bots/assets/android_ndk_linux/create.py:27: shutil.move(f, target_dir)
Why not just create a temporary dir, download and unzip there, and then move the
contents?

[mtklein_C, 2016-08-26 17:18:00]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:52:21]

Description was changed from

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003
==========

to

==========
add an asset for the Linux Android NDK.

I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003

Committed:
https://skia.googlesource.com/skia/+/5580c6913500ccd80fb03a72e6992ee0d5b42d88
==========

[commit-bot: I haz the power, 2016-08-26 17:52:22]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5580c6913500ccd80fb03a72e6992ee0d5b42d88