Translate ToolbarPhone buttons correctly in tab switcher.

Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597
Committed: https://crrev.com/eebaca541b6f84ad274fdcf18b5e13f631a5fd3a
Cr-Commit-Position: refs/heads/master@{#414498}

[PEConn, 2016-08-24 21:41:51]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org, mdjones@chromium.org

[PEConn, 2016-08-24 21:41:52]

Matthew and Bernhard, please take a look!

I managed to make the code a bit simpler and fix two bugs - the one linked and a
regression that I was going to report. You can find a before and after video in
the bug linked.

[PEConn, 2016-08-24 21:42:48]

Description was changed from

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The Buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

BUG=628597
==========

to

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597
==========

[PEConn, 2016-08-24 22:17:23]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mdjones, 2016-08-24 22:39:43]

lgtm

[commit-bot: I haz the power, 2016-08-24 23:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:34:50]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-08-25 09:03:59]

LGTM, thanks!

[PEConn, 2016-08-25 18:54:06]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-08-25 18:54:06]

The CQ bit was unchecked by peconn@chromium.org

[PEConn, 2016-08-25 18:54:12]

The CQ bit was checked by peconn@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:00:59]

Description was changed from

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597
==========

to

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597
==========

[commit-bot: I haz the power, 2016-08-25 19:01:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 19:03:04]

Description was changed from

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597
==========

to

==========
Translate ToolbarPhone buttons correctly in tab switcher.

The buttons in ToolbarPhone have their y translation modified to make it appear
like they are scrolling with the new tab page. This change fixes the calculation
to cancel this translation while in tab switcher mode.

In addition, this fixes a regression where the buttons would pop in after
defocusing the omnibox instead of sliding in from the side.

BUG=628597

Committed: https://crrev.com/eebaca541b6f84ad274fdcf18b5e13f631a5fd3a
Cr-Commit-Position: refs/heads/master@{#414498}
==========

[commit-bot: I haz the power, 2016-08-25 19:03:05]

Patchset 1 (id:??) landed as
https://crrev.com/eebaca541b6f84ad274fdcf18b5e13f631a5fd3a
Cr-Commit-Position: refs/heads/master@{#414498}