Blink-compatible serialization of ArrayBuffer transfer.

Blink-compatible serialization of ArrayBuffer transfer.

The embedder is expected to arrange for the array buffer contents to be
transferred into a v8::ArrayBuffer in the receiving context (generally by
assuming ownership of the externalized backing store).

BUG=chromium:148757
Committed: https://crrev.com/864728085d8eaa04199bd8f741e00beaaa58e3d4
Cr-Commit-Position: refs/heads/master@{#38948}

[jbroman, 2016-08-25 17:14:39]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 17:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:41:39]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-08-25 19:52:33]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2016-08-25 19:52:39]

SharedArrayBuffer will share the same map (because today they are indexed into
the same vector in blink::SerializedScriptValue), but it's not included in this
CL.

[Jakob Kummerow, 2016-08-26 12:22:40]

lgtm

https://codereview.chromium.org/2275033003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2275033003/diff/1/include/v8.h#newcode1734
include/v8.h:1734: * Provides the array buffer corresponding to the one passed
previously to
nit: I find the word "Provides" misleading here, because as a caller of this
method /I/ have to provide the value, and this function consumes it. How about
"takes" or "accepts" or "registers" or some other term that indicates input
rather than output?

[jbroman, 2016-08-26 15:16:06]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:16:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-08-26 15:16:23]

jbroman@chromium.org changed reviewers:
+ jochen@chromium.org

[jbroman, 2016-08-26 15:16:24]

+jochen for include/

https://codereview.chromium.org/2275033003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2275033003/diff/1/include/v8.h#newcode1734
include/v8.h:1734: * Provides the array buffer corresponding to the one passed
previously to
On 2016/08/26 at 12:22:40, Jakob wrote:
> nit: I find the word "Provides" misleading here, because as a caller of this
method /I/ have to provide the value, and this function consumes it. How about
"takes" or "accepts" or "registers" or some other term that indicates input
rather than output?

Done.

[jochen (gone - plz use gerrit), 2016-08-26 15:18:25]

lgtm

[jbroman, 2016-08-26 15:31:42]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2016-08-26 15:31:44]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-08-26 15:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2275033003/#ps20001
(title: "Accepts")

[commit-bot: I haz the power, 2016-08-26 15:31:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 15:47:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 15:47:48]

Description was changed from

==========
Blink-compatible serialization of ArrayBuffer transfer.

The embedder is expected to arrange for the array buffer contents to be
transferred into a v8::ArrayBuffer in the receiving context (generally by
assuming ownership of the externalized backing store).

BUG=chromium:148757
==========

to

==========
Blink-compatible serialization of ArrayBuffer transfer.

The embedder is expected to arrange for the array buffer contents to be
transferred into a v8::ArrayBuffer in the receiving context (generally by
assuming ownership of the externalized backing store).

BUG=chromium:148757

Committed: https://crrev.com/864728085d8eaa04199bd8f741e00beaaa58e3d4
Cr-Commit-Position: refs/heads/master@{#38948}
==========

[commit-bot: I haz the power, 2016-08-26 15:47:49]

Patchset 2 (id:??) landed as
https://crrev.com/864728085d8eaa04199bd8f741e00beaaa58e3d4
Cr-Commit-Position: refs/heads/master@{#38948}