Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 227503009: disable stack trace unittests for uClibc builds (Closed)

Created:
6 years, 8 months ago by Mostyn Bramley-Moore
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

disable stack trace unittests for uClibc builds Since we disabled StackTrace::OutputToStream and StackTrace::Print for uClibc builds, we should disable the related unittests for uClibc too. BUG=361130 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/debug/stack_trace_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@Mark: some unittest followup for the recent uClibc stack trace disabling...
6 years, 8 months ago (2014-04-10 08:16:23 UTC) #1
Mark Mentovai
LGTM
6 years, 8 months ago (2014-04-10 10:10:50 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-10 10:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/227503009/1
6 years, 8 months ago (2014-04-10 10:12:12 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 14:09:25 UTC) #5
Message was sent while issue was closed.
Change committed as 262984

Powered by Google App Engine
This is Rietveld 408576698