Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3142)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 22750002: Move AlterEnvironment to base/environment.h, implement on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index d151d5d682b1f423f2d827fddbea867c057b5735..d53203ba8db2206642a290e96feb2a11eb455321 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -161,13 +161,8 @@ Status LaunchDesktopChrome(
base::LaunchOptions options;
#if !defined(OS_WIN)
- base::EnvironmentVector environ;
- if (!capabilities.log_path.empty()) {
- environ.push_back(
- base::EnvironmentVector::value_type("CHROME_LOG_FILE",
- capabilities.log_path));
- options.environ = &environ;
- }
+ if (!capabilities.log_path.empty())
+ options.environ["CHROME_LOG_FILE"] = capabilities.log_path;
if (capabilities.detach)
options.new_process_group = true;
#endif

Powered by Google App Engine
This is Rietveld 408576698