chrome/test/chromedriver/chrome_launcher.cc - Issue 22750002: Move AlterEnvironment to base/environment.h, implement on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 22750002: Move AlterEnvironment to base/environment.h, implement on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index c9b0e4905498fa990e784c7fac4fc5c350f153d0..202c6fdaa49b685b882eeaf112acd3e4f4c4dec9 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -227,13 +227,8 @@ Status LaunchDesktopChrome(

base::LaunchOptions options;

#if !defined(OS_WIN)

- base::EnvironmentVector environ;

- if (!capabilities.log_path.empty()) {

- environ.push_back(

- base::EnvironmentVector::value_type("CHROME_LOG_FILE",

- capabilities.log_path));

- options.environ = &environ;

- }

+ if (!capabilities.log_path.empty())

+ options.environ["CHROME_LOG_FILE"] = capabilities.log_path;

if (capabilities.detach)

options.new_process_group = true;

#endif