Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h

Issue 2274993002: Make TabLayer recycling sticky to tab_id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h
diff --git a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h
index a446ba158a1d15ce769a9e19d89655b87bffc35d..6ab9e14e95c0a85b6f3b1c8dfb13ae501dee86c0 100644
--- a/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h
+++ b/chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h
@@ -5,8 +5,9 @@
#ifndef CHROME_BROWSER_ANDROID_COMPOSITOR_SCENE_LAYER_TAB_LIST_SCENE_LAYER_H_
#define CHROME_BROWSER_ANDROID_COMPOSITOR_SCENE_LAYER_TAB_LIST_SCENE_LAYER_H_
+#include <map>
#include <memory>
-#include <vector>
+#include <set>
#include "base/android/jni_android.h"
#include "base/android/jni_weak_ref.h"
@@ -111,20 +112,15 @@ class TabListSceneLayer : public SceneLayer {
SkColor GetBackgroundColor() override;
private:
- void RemoveAllRemainingTabLayers();
- void RemoveTabLayersInRange(unsigned start_index, unsigned end_index);
-
- typedef std::vector<scoped_refptr<TabLayer>> TabLayerList;
-
- scoped_refptr<TabLayer> GetNextLayer(bool incognito);
+ typedef std::map<int, scoped_refptr<TabLayer>> TabMap;
+ TabMap tab_map_;
+ std::set<int> visible_tabs_this_frame_;
base::android::ScopedJavaGlobalRef<jobject> java_obj_;
bool content_obscures_self_;
- unsigned write_index_;
ui::ResourceManager* resource_manager_;
LayerTitleCache* layer_title_cache_;
TabContentManager* tab_content_manager_;
- TabLayerList layers_;
SkColor background_color_;
scoped_refptr<cc::Layer> own_tree_;
« no previous file with comments | « no previous file | chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698