chrome/browser/engagement/site_engagement_service.h - Issue 2274973003: Enable site engagement in incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2274973003: Enable site engagement in incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address_nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_service.h

diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h

index 5d740b7fd2c91823779afa06ab4ef9b638766f58..d11fa3f6706abda5c4c96ba6efe4b98923af531a 100644

--- a/chrome/browser/engagement/site_engagement_service.h

+++ b/chrome/browser/engagement/site_engagement_service.h

@@ -133,6 +133,8 @@ class SiteEngagementService : public KeyedService,

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, Observers);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, ScoreDecayHistograms);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, LastEngagementTime);

+ FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,

+ IncognitoEngagementService);

FRIEND_TEST_ALL_PREFIXES(AppBannerSettingsHelperTest, SiteEngagementTrigger);

// Only used in tests.