chrome/browser/android/metrics/launch_metrics.cc - Issue 2274973003: Enable site engagement in incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/metrics/launch_metrics.cc

Issue 2274973003: Enable site engagement in incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address_nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/metrics/launch_metrics.cc

diff --git a/chrome/browser/android/metrics/launch_metrics.cc b/chrome/browser/android/metrics/launch_metrics.cc

index 345dd3193618a98bb616ecc9c07d8908baf55ed9..1c2eebb269b8714f8882df9be26b4a6b1571c3c1 100644

--- a/chrome/browser/android/metrics/launch_metrics.cc

+++ b/chrome/browser/android/metrics/launch_metrics.cc

@@ -56,8 +56,7 @@ static void RecordLaunch(JNIEnv* env,

// launched from a shortcut receive a boost to their engagement.

SiteEngagementService* service = SiteEngagementService::Get(

Profile::FromBrowserContext(web_contents->GetBrowserContext()));

- if (service)

- service->SetLastShortcutLaunchTime(url);

+ service->SetLastShortcutLaunchTime(url);

}

std::string rappor_metric_source;

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | no next file with comments »