Add a WebURLLoaderImplTest for a redirect response with no security info

content/child/web_url_loader_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/web_url_loader_impl.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include <utility>
@@ skipping 26 matching lines @@
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 #include "url/gurl.h"
 
 namespace content {
 namespace {
 
 const char kTestURL[] = "http://foo";
+const char kTestHTTPSURL[] = "https://foo";
 const char kTestData[] = "blah!";
 
 const char kFtpDirMimeType[] = "text/vnd.chromium.ftp-dir";
 // Simple FTP directory listing.  Tests are not concerned with correct parsing,
 // but rather correct cleanup when deleted while parsing.  Important details of
 // this list are that it contains more than one entry that are not "." or "..".
 const char kFtpDirListing[] =
     "drwxr-xr-x    3 ftp      ftp          4096 May 15 18:11 goat\n"
     "drwxr-xr-x    3 ftp      ftp          4096 May 15 18:11 hat";
 
@@ skipping 245 matching lines @@
     net::RedirectInfo redirect_info;
     redirect_info.status_code = 302;
     redirect_info.new_method = "GET";
     redirect_info.new_url = GURL(kTestURL);
     redirect_info.new_first_party_for_cookies = GURL(kTestURL);
     peer()->OnReceivedRedirect(redirect_info,
                                content::ResourceResponseInfo());
     EXPECT_TRUE(client()->did_receive_redirect());
   }
 
+  void DoReceiveHTTPSRedirect() {
+    EXPECT_FALSE(client()->did_receive_redirect());
+    net::RedirectInfo redirect_info;
+    redirect_info.status_code = 302;
+    redirect_info.new_method = "GET";
+    redirect_info.new_url = GURL(kTestHTTPSURL);
+    redirect_info.new_first_party_for_cookies = GURL(kTestHTTPSURL);
+    peer()->OnReceivedRedirect(redirect_info,
+                               content::ResourceResponseInfo());
+    EXPECT_TRUE(client()->did_receive_redirect());
+  }
+
   void DoReceiveResponse() {
     EXPECT_FALSE(client()->did_receive_response());
     peer()->OnReceivedResponse(content::ResourceResponseInfo());
     EXPECT_TRUE(client()->did_receive_response());
   }
 
   // Assumes it is called only once for a request.
   void DoReceiveData() {
     EXPECT_EQ("", client()->received_data());
     auto size = strlen(kTestData);
@@ skipping 60 matching lines @@
 TEST_F(WebURLLoaderImplTest, Redirect) {
   DoStartAsyncRequest();
   DoReceiveRedirect();
   DoReceiveResponse();
   DoReceiveData();
   DoCompleteRequest();
   EXPECT_FALSE(dispatcher()->canceled());
   EXPECT_EQ(kTestData, client()->received_data());
 }
 
+// Tests that a redirect to an HTTPS URL with no security info does not
+// crash. Regression test for https://crbug.com/519120
+TEST_F(WebURLLoaderImplTest, RedirectToHTTPSWithEmptySecurityInfo) {
+  DoStartAsyncRequest();
+  DoReceiveHTTPSRedirect();
+  DoReceiveResponse();
+  DoReceiveData();
+  DoCompleteRequest();
+  EXPECT_FALSE(dispatcher()->canceled());
+  EXPECT_EQ(kTestData, client()->received_data());
+}
+
 TEST_F(WebURLLoaderImplTest, RedirectCorrectPriority) {
   DoStartAsyncRequestWithPriority(
       blink::WebURLRequest::Priority::PriorityVeryHigh);
   client()->set_redirect_request_priority(
       blink::WebURLRequest::Priority::PriorityVeryHigh);
   DoReceiveRedirect();
   DoReceiveResponse();
   DoReceiveData();
   DoCompleteRequest();
   EXPECT_FALSE(dispatcher()->canceled());
@@ skipping 296 matching lines @@
                                         encoded_data_length);
 
   EXPECT_EQ(kEncodedBodyLength, response.encodedBodyLength());
   EXPECT_EQ(kEncodedDataLength, encoded_data_length);
   int expected_decoded_body_length = strlen(kBodyData);
   EXPECT_EQ(expected_decoded_body_length, response.decodedBodyLength());
 }
 
 }  // namespace
 }  // namespace content