Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2274933002: Add some more categories for V8.TodoMVC to see what keeps us non-idle (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some more categories for V8.TodoMVC to see what keeps us non-idle BUG=636405 R=skyostil@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/2c3cb38333c08f67b50e482aad3674a7bbfed6be Cr-Commit-Position: refs/heads/master@{#414187}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +1 line, -0 lines 1 comment Download
M tools/perf/page_sets/todomvc.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-24 16:07:29 UTC) #1
Sami
lgtm. https://codereview.chromium.org/2274933002/diff/1/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/2274933002/diff/1/tools/perf/benchmarks/v8.py#newcode26 tools/perf/benchmarks/v8.py:26: category_filter.AddIncludedCategory('blink') Did you mean to add toplevel too? ...
4 years, 4 months ago (2016-08-24 16:40:17 UTC) #5
jochen (gone - plz use gerrit)
On 2016/08/24 at 16:40:17, skyostil wrote: > lgtm. > > https://codereview.chromium.org/2274933002/diff/1/tools/perf/benchmarks/v8.py > File tools/perf/benchmarks/v8.py (right): ...
4 years, 4 months ago (2016-08-24 20:38:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274933002/1
4 years, 4 months ago (2016-08-24 20:38:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 23:04:48 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c3cb38333c08f67b50e482aad3674a7bbfed6be Cr-Commit-Position: refs/heads/master@{#414187}
4 years, 4 months ago (2016-08-24 23:06:17 UTC) #13
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-02 13:25:51 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2306073002/ by jochen@chromium.org.

The reason for reverting is: no longer needed.

Powered by Google App Engine
This is Rietveld 408576698