Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227493006: Revert 262175 "* Replace "read" method with onReceiveXxx events." (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
rpaquay
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 262175 "* Replace "read" method with onReceiveXxx events." Failed compile on Linux CrOS Full: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/2043/steps/compile/logs/stdio > * Replace "read" method with onReceiveXxx events. > * Few minor changes to idl file. > * Socket implementation on Windows fully implemented and with (hopefully) correct threading usage. > * ChromeOS and MacOS socket implementation empty for now (they will come in later CLs). > > BUG=336824, 340363, 340413, 343651, 344081 > > Review URL: https://codereview.chromium.org/180163009 TBR=rpaquay@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -2540 lines) Patch
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 8 chunks +61 lines, -194 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 10 chunks +167 lines, -452 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api_socket.h View 1 chunk +0 lines, -125 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api_socket.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api_unittest.cc View 1 chunk +0 lines, -207 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 5 chunks +9 lines, -22 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 3 chunks +29 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 20 chunks +78 lines, -26 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 5 chunks +117 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_private_api.cc View 2 chunks +7 lines, -5 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.h View 1 chunk +0 lines, -81 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_socket_event_dispatcher.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/api/bluetooth.idl View 9 chunks +50 lines, -133 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/bluetooth/on_connection/runtest.js View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/device/bluetooth/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/device/bluetooth/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_adapter.h View 7 chunks +25 lines, -25 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_adapter_win.h View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_adapter_win.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device.h View 2 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_chromeos.h View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_mac.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win.h View 3 chunks +2 lines, -12 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win.cc View 3 chunks +20 lines, -22 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win_unittest.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_win.h View 3 chunks +1 line, -13 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_win.cc View 2 chunks +11 lines, -83 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket.h View 2 chunks +17 lines, -42 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_socket.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_chromeos.h View 2 chunks +10 lines, -12 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_chromeos.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_mac.h View 2 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_mac.mm View 2 chunks +1 line, -22 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_socket_thread_win.h View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_socket_thread_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_win.h View 1 chunk +15 lines, -96 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_socket_win.cc View 2 chunks +59 lines, -346 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_task_manager_win.cc View 3 chunks +35 lines, -48 lines 0 comments Download
M trunk/src/device/bluetooth/test/mock_bluetooth_device.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/test/mock_bluetooth_socket.h View 1 chunk +10 lines, -12 lines 0 comments Download
M trunk/src/extensions/browser/api/api_resource_manager.h View 3 chunks +14 lines, -31 lines 0 comments Download
M trunk/src/extensions/browser/api/async_api_function.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
6 years, 8 months ago (2014-04-07 19:58:14 UTC) #1
scottmg
6 years, 8 months ago (2014-04-07 19:58:54 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r262180 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698