Issue 227493005: Added files missing from revision 159.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227493005: Added files missing from revision 159. (Closed)

Created:
6 years, 8 months ago by Joao da Silva

Modified:
6 years, 8 months ago

Reviewers:
pastarmovj

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added files missing from revision 159. BUG=360508 TBR=pastarmovj@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=160

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+332 lines, -0 lines)			Patch
	A	grit/format/policy_templates/writers/ios_plist_writer.py	View		1 chunk	+123 lines, -0 lines	0 comments	Download
	A	grit/format/policy_templates/writers/ios_plist_writer_unittest.py	View		1 chunk	+209 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Committed patchset #1 manually as r160 (presubmit successful).

6 years, 8 months ago (2014-04-07 17:20:16 UTC) #1

Joao da Silva

6 years, 8 months ago (2014-04-07 17:20:52 UTC) #2

Message was sent while issue was closed.

Missed this files from the previous CL at
https://codereview.chromium.org/227073006.

This happened because I applied the patch locally, but new files must be "svn
added" manually :-(

Expand Messages | Collapse Messages