Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2274913002:
Turning on change password form support in Password Manager on Android by default. (Closed)
|
Created:
4 years, 3 months ago by dvadym Modified:
4 years, 3 months ago Reviewers:
vabr (Chromium) CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTurning on change password form support in Password Manageron Android by default.
On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok.
BUG=564674
Committed: https://crrev.com/55c657b60fc7cd327e1a8586897d5ed8fd4665aa
Cr-Commit-Position: refs/heads/master@{#414350}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by dvadym@chromium.org to run a CQ dry run
Description was changed from ========== Turning off change password form support on Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it. BUG=564674 ========== to ========== Turning on change password form support on Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it. BUG=564674 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Turning on change password form support on Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it. BUG=564674 ========== to ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it. BUG=564674 ==========
dvadym@chromium.org changed reviewers: + vabr@chromium.org
Hi Vaclav, Could you please review this CL? Regards, Vadym
Description was changed from ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it. BUG=564674 ========== to ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok. BUG=564674 ==========
LGTM!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dvadym@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok. BUG=564674 ========== to ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok. BUG=564674 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok. BUG=564674 ========== to ========== Turning on change password form support in Password Manageron Android by default. On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok. BUG=564674 Committed: https://crrev.com/55c657b60fc7cd327e1a8586897d5ed8fd4665aa Cr-Commit-Position: refs/heads/master@{#414350} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/55c657b60fc7cd327e1a8586897d5ed8fd4665aa Cr-Commit-Position: refs/heads/master@{#414350} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
