Fix ScriptCustomElementDefinition::createElementSync to use the given document

third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CustomElementDefinition_h
 #define CustomElementDefinition_h
 
 #include "bindings/core/v8/ScriptValue.h"
 #include "core/CoreExport.h"
 #include "core/dom/custom/CustomElementDescriptor.h"
@@ skipping 30 matching lines @@
     // |getConstructorForScript()| by |getConstructor() ->
     // CustomElementConstructor|.
     virtual ScriptValue getConstructorForScript() = 0;
 
     using ConstructionStack = HeapVector<Member<Element>, 1>;
     ConstructionStack& constructionStack()
     {
         return m_constructionStack;
     }
 
+    HTMLElement* createElementForConstructor(Document&);
     virtual HTMLElement* createElementSync(Document&, const QualifiedName&) = 0;
     virtual HTMLElement* createElementSync(Document&, const QualifiedName&, ExceptionState&) = 0;
     HTMLElement* createElementAsync(Document&, const QualifiedName&);
 
     void upgrade(Element*);
 
     virtual bool hasConnectedCallback() const = 0;
     virtual bool hasDisconnectedCallback() const = 0;
     virtual bool hasAdoptedCallback() const = 0;
     bool hasAttributeChangedCallback(const QualifiedName&) const;
     bool hasStyleAttributeChangedCallback() const;
 
     virtual void runConnectedCallback(Element*) = 0;
     virtual void runDisconnectedCallback(Element*) = 0;
     virtual void runAdoptedCallback(Element*) = 0;
     virtual void runAttributeChangedCallback(Element*, const QualifiedName&,
         const AtomicString& oldValue, const AtomicString& newValue) = 0;
 
     void enqueueUpgradeReaction(Element*);
     void enqueueConnectedCallback(Element*);
     void enqueueDisconnectedCallback(Element*);
     void enqueueAdoptedCallback(Element*);
     void enqueueAttributeChangedCallback(Element*, const QualifiedName&,
         const AtomicString& oldValue, const AtomicString& newValue);
 
+    class CORE_EXPORT ConstructionStackScope final {

[kochi, 2016/08/25 08:18:11]

ScopedConstructionStack?
(I don't have strong opinion here for naming, just my preference)

[kojii, 2016/08/25 09:01:17]

We have CEReactionsScope, if not strong, allow me to take the consistency with
it.

[kochi, 2016/08/25 09:12:19]

Acknowledged.

+        STACK_ALLOCATED();
+        WTF_MAKE_NONCOPYABLE(ConstructionStackScope);

[tkent, 2016/08/25 09:03:35]

nit: Let's use DISALLOW_COPY_AND_ASSIGN(ConstructionStackScope) for new class.

+    public:
+        ConstructionStackScope(CustomElementDefinition*, Element*);
+        ~ConstructionStackScope();
+
+    private:
+        ConstructionStack& m_constructionStack;
+        Member<Element> m_element;
+        size_t m_depth;

[kochi, 2016/08/25 08:18:11]

Looks like m_element and m_depth are only used for DCHECK?

If so, enclose them '#ifdef DCHECK_IS_ON() ~ #endif'.

[kojii, 2016/08/25 09:01:17]

Done.

+    };
 protected:
     virtual bool runConstructor(Element*) = 0;
 
     static void checkConstructorResult(Element*, Document&, const QualifiedName&, ExceptionState&);
 
 private:
     const CustomElementDescriptor m_descriptor;
     ConstructionStack m_constructionStack;
     HashSet<AtomicString> m_observedAttributes;
     bool m_hasStyleAttributeChangedCallback;
 
     void enqueueAttributeChangedCallbackForAllAttributes(Element*);
 };
 
 } // namespace blink
 
 #endif // CustomElementDefinition_h