Fix ScriptCustomElementDefinition::createElementSync to use the given document

third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementDefinition.h"
 
 #include "core/dom/Attr.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/custom/CustomElement.h"
 #include "core/dom/custom/CustomElementAdoptedCallbackReaction.h"
@@ skipping 66 matching lines @@
         exceptionState.throwTypeError("The result must implement HTMLElement interface");
         return;
     }
 
     // 6.1.4. through 6.1.9.
     const String message = errorMessageForConstructorResult(element, document, tagName);
     if (!message.isEmpty())
         exceptionState.throwDOMException(NotSupportedError, message);
 }
 
+HTMLElement* CustomElementDefinition::createElementForConstructor(
+    Document& document)
+{
+    // TODO(kojii): When HTMLElementFactory has an option not to queue
+    // upgrade, call that instead of HTMLElement. HTMLElement is enough
+    // for now, but type extension will require HTMLElementFactory.
+    HTMLElement* element = HTMLElement::create(
+        QualifiedName(nullAtom, descriptor().localName(),
+            HTMLNames::xhtmlNamespaceURI),
+        document);
+    // TODO(davaajav): write this as one call to setCustomElementState instead of two
+    element->setCustomElementState(CustomElementState::Undefined);
+    element->setCustomElementDefinition(this);
+    return element;
+}
+
 HTMLElement* CustomElementDefinition::createElementAsync(Document& document, const QualifiedName& tagName)
 {
     // https://dom.spec.whatwg.org/#concept-create-element
     // 6. If definition is non-null, then:
     // 6.2. If the synchronous custom elements flag is not set:
     // 6.2.1. Set result to a new element that implements the HTMLElement
     // interface, with no attributes, namespace set to the HTML namespace,
     // namespace prefix set to prefix, local name set to localName, custom
     // element state set to "undefined", and node document set to document.
     HTMLElement* element = HTMLElement::create(tagName, document);
     element->setCustomElementState(CustomElementState::Undefined);
     // 6.2.2. Enqueue a custom element upgrade reaction given result and
     // definition.
     enqueueUpgradeReaction(element);
     return element;
 }
 
+CustomElementDefinition::ConstructionStackScope::ConstructionStackScope(
+    CustomElementDefinition* definition, Element* element)
+    : m_constructionStack(definition->m_constructionStack)
+    , m_element(element)
+{
+    // Push the construction stack.
+    m_constructionStack.append(element);
+    m_depth = m_constructionStack.size();
+}
+
+CustomElementDefinition::ConstructionStackScope::~ConstructionStackScope()
+{
+    // Pop the construction stack.
+    if (m_constructionStack.last().get())
+        DCHECK_EQ(m_constructionStack.last(), m_element);
+    DCHECK_EQ(m_constructionStack.size(), m_depth); // It's a *stack*.
+    m_constructionStack.removeLast();
+}
+
 // https://html.spec.whatwg.org/multipage/scripting.html#concept-upgrade-an-element
 void CustomElementDefinition::upgrade(Element* element)
 {
     DCHECK_EQ(element->getCustomElementState(), CustomElementState::Undefined);
 
     if (!m_observedAttributes.isEmpty())
         enqueueAttributeChangedCallbackForAllAttributes(element);
 
     if (element->isConnected() && hasConnectedCallback())
         enqueueConnectedCallback(element);
 
-    m_constructionStack.append(element);
-    size_t depth = m_constructionStack.size();
-
-    bool succeeded = runConstructor(element);
-
-    // Pop the construction stack.
-    if (m_constructionStack.last().get())
-        DCHECK_EQ(m_constructionStack.last(), element);
-    DCHECK_EQ(m_constructionStack.size(), depth); // It's a *stack*.
-    m_constructionStack.removeLast();
-
+    bool succeeded = false;
+    {
+        ConstructionStackScope constructionStackScope(this, element);
+        succeeded = runConstructor(element);
+    }
     if (!succeeded) {
         element->setCustomElementState(CustomElementState::Failed);
         return;
     }
 
     element->setCustomElementDefinition(this);
 }
 
 bool CustomElementDefinition::hasAttributeChangedCallback(
     const QualifiedName& name) const
@@ skipping 49 matching lines @@
         element->synchronizeAttribute(name);
     for (const auto& attribute : element->attributesWithoutUpdate()) {
         if (hasAttributeChangedCallback(attribute.name())) {
             enqueueAttributeChangedCallback(element, attribute.name(),
                 nullAtom, attribute.value());
         }
     }
 }
 
 } // namespace blink