Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2274883004: Ship Custom Elements v1 (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Custom Elements v1 Flip CustomElementsV1 flag in RuntimeEnabledFeatures to stable. Got 3 LGTMs for Intent-to-Ship in blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/P2UKXfsFWWE/discussion BUG=594918 Committed: https://crrev.com/ed691cd596251a924dafddd9e7402f8259fe1167 Cr-Commit-Position: refs/heads/master@{#414395}

Patch Set 1 #

Patch Set 2 : Update global-interface-listing expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
kochi
tkent-san, Could you review this?
4 years, 3 months ago (2016-08-25 08:41:45 UTC) #9
tkent
lgtm
4 years, 3 months ago (2016-08-25 08:43:21 UTC) #10
kojii
lgtm, thank you.
4 years, 3 months ago (2016-08-25 09:13:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274883004/20001
4 years, 3 months ago (2016-08-25 09:15:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 11:30:13 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:32:01 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed691cd596251a924dafddd9e7402f8259fe1167
Cr-Commit-Position: refs/heads/master@{#414395}

Powered by Google App Engine
This is Rietveld 408576698