[sql] Track SQLite error codes from sql::Recovery ATTACH.

[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org

Committed: https://crrev.com/631881144b032483cd60b26e054539fd819b6713
Cr-Commit-Position: refs/heads/master@{#414885}

[Scott Hess - ex-Googler, 2016-08-24 22:53:10]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2016-08-25 00:42:42]

Description was changed from

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database.

BUG=597785
R=michaeln@chromium.org
==========

to

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org
==========

[Scott Hess - ex-Googler, 2016-08-25 00:43:48]

OK, looks like many trybots are happy with this...

[commit-bot: I haz the power, 2016-08-25 00:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:56:43]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[michaeln, 2016-08-25 21:59:27]

lgtm

[Scott Hess - ex-Googler, 2016-08-26 15:10:52]

shess@chromium.org changed reviewers:
+ isherman@chromium.org

[Scott Hess - ex-Googler, 2016-08-26 15:10:53]

+Ilya for histograms.xml.

[Ilya Sherman, 2016-08-26 21:45:04]

metrics lgtm

[Scott Hess - ex-Googler, 2016-08-26 23:48:20]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-08-26 23:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:27:07]

Description was changed from

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org
==========

to

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org
==========

[commit-bot: I haz the power, 2016-08-27 10:27:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-27 10:28:53]

Description was changed from

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org
==========

to

==========
[sql] Track SQLite error codes from sql::Recovery ATTACH.

The major reason for sql::Recover::Begin() to fail is in the statement
attaching the original database to the recovery database.  I believe
this is because of SQLITE_NOTADB.  This is to verify that hypothesis.
If the hypothesis is true, then the best course of action is to Raze()
the database, as SQLITE_NOTADB means that some or all of the SQLite
header data appears to be garbage.

BUG=597785
R=michaeln@chromium.org

Committed: https://crrev.com/631881144b032483cd60b26e054539fd819b6713
Cr-Commit-Position: refs/heads/master@{#414885}
==========

[commit-bot: I haz the power, 2016-08-27 10:28:55]

Patchset 1 (id:??) landed as
https://crrev.com/631881144b032483cd60b26e054539fd819b6713
Cr-Commit-Position: refs/heads/master@{#414885}