Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: content/browser/media/session/media_session.cc

Issue 2274873003: Letting Flash join MediaSession (stack implementaion) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session_type
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session.cc
diff --git a/content/browser/media/session/media_session.cc b/content/browser/media/session/media_session.cc
index c95ab3b5784069a8ab41a26600c3c976d7751188..98c3898456dbdd7006b7750c587618fd3a2d393d 100644
--- a/content/browser/media/session/media_session.cc
+++ b/content/browser/media/session/media_session.cc
@@ -60,6 +60,11 @@ MediaSession::~MediaSession() {
DCHECK(audio_focus_state_ == State::INACTIVE);
}
+void MediaSession::WasShown() {
+ if (IsSuspended())
+ RequestSystemAudioFocus(audio_focus_type_);
+}
+
void MediaSession::SetMetadata(const MediaMetadata& metadata) {
metadata_ = metadata;
// TODO(zqzhang): On Android, the metadata is sent though JNI everytime the
@@ -71,6 +76,9 @@ void MediaSession::SetMetadata(const MediaMetadata& metadata) {
bool MediaSession::AddPlayer(MediaSessionObserver* observer,
int player_id,
media::MediaContentType media_content_type) {
+ if (media_content_type == media::MediaContentType::Pepper)
+ return AddPepperPlayer(observer, player_id);
+
observer->OnSetVolumeMultiplier(player_id, GetVolumeMultiplier());
// Determine the audio focus type required for playing the new player.
@@ -122,6 +130,10 @@ void MediaSession::RemovePlayer(MediaSessionObserver* observer,
if (it != players_.end())
players_.erase(it);
+ it = pepper_players_.find(PlayerIdentifier(observer, player_id));
+ if (it != pepper_players_.end())
+ pepper_players_.erase(it);
+
AbandonSystemAudioFocusIfNeeded();
}
@@ -133,6 +145,13 @@ void MediaSession::RemovePlayers(MediaSessionObserver* observer) {
++it;
}
+ for (auto it = pepper_players_.begin(); it != pepper_players_.end();) {
whywhat 2016/09/07 20:09:54 nit: add a space between ; and )
Zhiqiang Zhang (Slow) 2016/09/08 14:18:26 Done.
+ if (it->observer == observer)
+ pepper_players_.erase(it++);
+ else
+ ++it;
+ }
+
AbandonSystemAudioFocusIfNeeded();
}
@@ -204,6 +223,11 @@ void MediaSession::Stop(SuspendType suspend_type) {
DCHECK(audio_focus_state_ == State::SUSPENDED);
players_.clear();
+
+ for (const auto& it : pepper_players_)
whywhat 2016/09/07 20:09:54 nit: add {}
Zhiqiang Zhang (Slow) 2016/09/08 14:18:26 Done.
+ it.observer->OnSetVolumeMultiplier(
+ it.player_id, GetPepperVolumeMultiplier());
+
AbandonSystemAudioFocusIfNeeded();
}
@@ -230,6 +254,14 @@ double MediaSession::GetVolumeMultiplier() const {
return is_ducking_ ? kDuckingVolumeMultiplier : kDefaultVolumeMultiplier;
}
+double MediaSession::GetPepperVolumeMultiplier() const {
+ if (is_on_top_)
+ return kDefaultVolumeMultiplier;
+ if (!IsActive() || is_ducking_)
+ return kDuckingVolumeMultiplier;
+ return kDefaultVolumeMultiplier;
+}
+
bool MediaSession::IsActive() const {
return audio_focus_state_ == State::ACTIVE;
}
@@ -323,6 +355,9 @@ void MediaSession::OnSuspendInternal(SuspendType suspend_type,
it.observer->OnSuspend(it.player_id);
}
+ for (const auto& it : pepper_players_)
+ it.observer->OnSetVolumeMultiplier(it.player_id, kDuckingVolumeMultiplier);
+
UpdateWebContents();
}
@@ -335,6 +370,10 @@ void MediaSession::OnResumeInternal(SuspendType suspend_type) {
for (const auto& it : players_)
it.observer->OnResume(it.player_id);
+ for (const auto& it : pepper_players_)
+ it.observer->OnSetVolumeMultiplier(
+ it.player_id, GetPepperVolumeMultiplier());
+
UpdateWebContents();
}
@@ -343,7 +382,8 @@ MediaSession::MediaSession(WebContents* web_contents)
audio_focus_state_(State::INACTIVE),
audio_focus_type_(
AudioFocusManager::AudioFocusType::GainTransientMayDuck),
- is_ducking_(false) {}
+ is_ducking_(false),
+ is_on_top_(false) {}
void MediaSession::Initialize() {
delegate_ = MediaSessionDelegate::Create(this);
@@ -357,7 +397,8 @@ bool MediaSession::RequestSystemAudioFocus(
}
void MediaSession::AbandonSystemAudioFocusIfNeeded() {
- if (audio_focus_state_ == State::INACTIVE || !players_.empty())
+ if (audio_focus_state_ == State::INACTIVE || !players_.empty() ||
+ !pepper_players_.empty())
return;
delegate_->AbandonAudioFocus();
@@ -389,4 +430,30 @@ void MediaSession::SetAudioFocusState(State audio_focus_state) {
}
}
+bool MediaSession::AddPepperPlayer(MediaSessionObserver* observer,
+ int player_id) {
+ AudioFocusManager::AudioFocusType focus_type =
+ AudioFocusManager::AudioFocusType::Gain;
+ State audio_focus_state =
+ RequestSystemAudioFocus(focus_type) ? State::ACTIVE : State::INACTIVE;
+ SetAudioFocusState(audio_focus_state);
+ audio_focus_type_ = focus_type;
+ pepper_players_.insert(PlayerIdentifier(observer, player_id));
+
+ observer->OnSetVolumeMultiplier(player_id, GetPepperVolumeMultiplier());
+
+ return true;
+}
+
+void MediaSession::SetOnTop(bool is_on_top) {
+ if (is_on_top_ == is_on_top)
+ return;
+
+ is_on_top_ = is_on_top;
+ for (const auto& it : pepper_players_) {
+ it.observer->OnSetVolumeMultiplier(
+ it.player_id, GetPepperVolumeMultiplier());
+ }
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698