content/browser/media/session/media_session_browsertest.cc - Issue 2274873003: Letting Flash join MediaSession (stack implementaion)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_browsertest.cc

Issue 2274873003: Letting Flash join MediaSession (stack implementaion) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session_type

Patch Set: addressed Anton's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/session/media_session_browsertest.cc

diff --git a/content/browser/media/session/media_session_browsertest.cc b/content/browser/media/session/media_session_browsertest.cc

index bf49031b61a1ee875e4372b5b245acbab85acd1a..629c562c0f6babac2e10fbee35735d803e9a93d3 100644

--- a/content/browser/media/session/media_session_browsertest.cc

+++ b/content/browser/media/session/media_session_browsertest.cc

@@ -114,7 +114,7 @@ class MediaSessionBrowserTest : public content::ContentBrowserTest {

bool HasAudioFocus() { return media_session_->IsActiveForTest(); }

content::AudioFocusManager::AudioFocusType GetSessionAudioFocusType() {

- return media_session_->audio_focus_type_for_test();

+ return media_session_->audio_focus_type();

mlamouri (slow - plz ping) 2016/09/30 09:35:22 Don't you only use that in test?

Zhiqiang Zhang (Slow) 2016/09/30 10:04:43 AudioFocusManager also uses this :)

}

bool IsControllable() { return media_session_->IsControllable(); }

« content/browser/media/session/media_session.cc ('K') | « content/browser/media/session/media_session.cc ('k') | content/test/BUILD.gn » ('j') | content/test/BUILD.gn » ('J')