include/core/SkPostConfig.h - Issue 2274863002: sk_at_scope_end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPostConfig.h

Issue 2274863002: sk_at_scope_end (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: use it! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPostConfig.h

diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h

index 97c868f30febc7f057bb5c7da8aa9d066203660f..384dbe9d40585075361fca1aad840394ed9c5d6a 100644

--- a/include/core/SkPostConfig.h

+++ b/include/core/SkPostConfig.h

@@ -245,7 +245,11 @@

//////////////////////////////////////////////////////////////////////

#if !defined(SK_UNUSED)

-# define SK_UNUSED SK_ATTRIBUTE(unused)

+ #if defined(_MSC_VER)

+ #define SK_UNUSED __pragma(warning(suppress:4189))

bungeman-skia 2016/08/24 15:18:17 Won't this suppress the warning for the entire res

mtklein 2016/08/24 16:52:58 I don't think so. As far as I can tell, suppress e

+ #else

+ #define SK_UNUSED SK_ATTRIBUTE(unused)

+ #endif

#endif

#if !defined(SK_ATTR_DEPRECATED)

« no previous file with comments | « no previous file | include/private/SkTemplates.h » ('j') | include/private/SkTemplates.h » ('J')