Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2274833002: Teach mojo::Watcher in URLResponseBodyConsumer the correct task runner (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
jam, tzik
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach mojo::Watcher in URLResponseBodyConsumer the correct task runner This CL makes mojo::Watcher run on the correct task runner instead of the default task runner of the main thread. BUG=603396 Committed: https://crrev.com/4db6bf82982a5755e26f23f5442f018212fbe059 Cr-Commit-Position: refs/heads/master@{#415537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/url_response_body_consumer.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/child/url_response_body_consumer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
yhirano
4 years, 3 months ago (2016-08-24 10:29:47 UTC) #6
yhirano
ping
4 years, 3 months ago (2016-08-29 01:56:01 UTC) #7
tzik
sorry for delay. LGTM.
4 years, 3 months ago (2016-08-30 02:22:40 UTC) #8
yhirano
jam@, could you take a look?
4 years, 3 months ago (2016-08-30 02:24:26 UTC) #10
jam
lgtm
4 years, 3 months ago (2016-08-30 16:38:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274833002/1
4 years, 3 months ago (2016-08-31 00:43:42 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 01:55:47 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:59:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db6bf82982a5755e26f23f5442f018212fbe059
Cr-Commit-Position: refs/heads/master@{#415537}

Powered by Google App Engine
This is Rietveld 408576698