Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 227483006: Version 3.25.28.6 (merged r20316, r20366, r20428, r20451) (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Version 3.25.28.6 (merged r20316, r20366, r20428, r20451) Don't pass the hole to SetElement when creating Array.observe change records Fix Type::Intersect to skip uninhabited bitsets Make invalid LHSs that are calls late errors BUG=chromium:356589, chromium:357330, chromium:358346 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -274 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ast.h View 7 chunks +28 lines, -25 lines 0 comments Download
M src/ast.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/parser.h View 4 chunks +24 lines, -23 lines 0 comments Download
M src/parser.cc View 8 chunks +66 lines, -79 lines 0 comments Download
M src/preparser.h View 12 chunks +67 lines, -40 lines 0 comments Download
M src/preparser.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/types.cc View 6 chunks +23 lines, -25 lines 0 comments Download
M src/variables.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/variables.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +10 lines, -1 line 0 comments Download
M test/mjsunit/invalid-lhs.js View 2 chunks +15 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-356589.js View 1 chunk +6 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-357330.js View 1 chunk +9 lines, -12 lines 0 comments Download
M test/webkit/fast/js/modify-non-references.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/webkit/fast/js/modify-non-references-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 8 months ago (2014-04-07 09:56:46 UTC) #1
Michael Achenbach
lgtm
6 years, 8 months ago (2014-04-07 10:40:34 UTC) #2
rossberg
6 years, 8 months ago (2014-04-07 10:48:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20536.

Powered by Google App Engine
This is Rietveld 408576698