Add flags to FrameArray

Add flags to FrameArray

This makes some information passed implicitly (e.g. the ForceConstructor
flag used to be a special symbol passed as the receiver) explicit.

BUG=

Committed: https://crrev.com/eba4ae235734fa8a5240130711bc7fb52da83ee3
Cr-Commit-Position: refs/heads/master@{#38870}

[jgruber, 2016-08-24 07:44:24]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 07:44:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:08:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:08:20]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-24 08:13:16]

jgruber@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-08-24 14:36:39]

lgtm

https://codereview.chromium.org/2274823002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2274823002/diff/1/src/isolate.cc#newcode356
src/isolate.cc:356: encountered_strict_function_ =
is_strict(fun->shared()->language_mode());
this should just be return fun->shared()->language_mode()? There's no guarantee
regarding strictness and stack-depth?

[jgruber, 2016-08-24 15:12:19]

https://codereview.chromium.org/2274823002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2274823002/diff/1/src/isolate.cc#newcode356
src/isolate.cc:356: encountered_strict_function_ =
is_strict(fun->shared()->language_mode());
On 2016/08/24 14:36:39, Toon Verwaest wrote:
> this should just be return fun->shared()->language_mode()? There's no
guarantee
> regarding strictness and stack-depth?

That behavior goes back to https://chromiumcodereview.appspot.com/13150003
(poison stack frames below the first strict mode frame). Adding a comment to
clarify.

[jgruber, 2016-08-24 15:13:38]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-08-24 15:13:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2274823002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-24 15:13:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:41:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 15:41:20]

Description was changed from

==========
Add flags to FrameArray

This makes some information passed implicitly (e.g. the ForceConstructor
flag used to be a special symbol passed as the receiver) explicit.

BUG=
==========

to

==========
Add flags to FrameArray

This makes some information passed implicitly (e.g. the ForceConstructor
flag used to be a special symbol passed as the receiver) explicit.

BUG=

Committed: https://crrev.com/eba4ae235734fa8a5240130711bc7fb52da83ee3
Cr-Commit-Position: refs/heads/master@{#38870}
==========

[commit-bot: I haz the power, 2016-08-24 15:41:21]

Patchset 3 (id:??) landed as
https://crrev.com/eba4ae235734fa8a5240130711bc7fb52da83ee3
Cr-Commit-Position: refs/heads/master@{#38870}