Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2274813002: Reland of land #2 of Enable whitelist generation for official builds. (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of land #2 of Enable whitelist generation for official builds. (patchset #1 id:1 of https://codereview.chromium.org/2277523002/ ) Reason for revert: want to test that manual tryjob can be used to detect next failure. Original issue's description: > Revert of Reland #2 of Enable whitelist generation for official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2271673002/ ) > > Reason for revert: > Breaking perf try bot https://build.chromium.org/p/tryserver.chromium.perf/builders/android_perf_bisect_builder/builds/14535/steps/compile/logs/stdio > > Original issue's description: > > Reland #2 of Enable whitelist generation for official builds. > > > > Previous: https://codereview.chromium.org/2241383004/ > > > > Currently, all resources are included in PAK files when Chrome is > > built locally. Only official_buildbot.sh uses a resource whitelist. This CL > > enables local builds to use resource whitelisting by setting the > > enable_resource_whitelist_generation gn flag to true, or by building an > > official build. > > > > This will allow developers to more easily monitor the changes in APK size > > for each commit they make. > > > > However, a large amount of output is generated (_pragma is used to > > create warnings to allow whitelisted resources to be listed), so for now > > the whitelist will only be generated for official builds. > > > > This change results in a ~1.5 mb difference when calculating the APK size with resource_sizes.py. > > > > BUG=632385 > > > > Committed: https://crrev.com/c7e6104c8c2ed8080115e92ff3c6f9d748e7feae > > Cr-Commit-Position: refs/heads/master@{#413794} > > TBR=agrieve@chromium.org,dpranke@chromium.org,estevenson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=632385 > > Committed: https://crrev.com/e925fbcc80e35d175d10b72be9c544f89c1bf5f1 > Cr-Commit-Position: refs/heads/master@{#413860} TBR=dpranke@chromium.org,estevenson@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -147 lines) Patch
M build/toolchain/gcc_ar_wrapper.py View 3 chunks +10 lines, -15 lines 0 comments Download
A build/toolchain/gcc_compile_wrapper.py View 1 chunk +44 lines, -0 lines 0 comments Download
M build/toolchain/gcc_solink_wrapper.py View 5 chunks +16 lines, -21 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 6 chunks +33 lines, -2 lines 0 comments Download
A build/toolchain/wrapper_utils.py View 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 4 chunks +41 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 4 chunks +12 lines, -5 lines 0 comments Download
M tools/grit/grit/format/repack.py View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +7 lines, -3 lines 0 comments Download
M tools/grit/repack.gni View 2 chunks +6 lines, -10 lines 0 comments Download
D tools/resources/find_used_resources.py View 1 chunk +0 lines, -89 lines 0 comments Download
A tools/resources/generate_resource_whitelist.py View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agrieve
Created Reland of land #2 of Enable whitelist generation for official builds.
4 years, 4 months ago (2016-08-24 03:46:52 UTC) #1
Dirk Pranke
4 years, 4 months ago (2016-08-24 15:25:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698