Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2274803003: add pathops debugging (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add pathops debugging Pathops has many points of failure, most of which are triggered by extreme data generated by fuzzers. It's difficult to figure out which failure point was triggered when the operation gives up. Add instrumentation so that the failure can be debugged when the data is well-behaved. Also, add a check that looks for a sequence of coincident points on multiple edges that are out of order when compared to each other. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274803003 Committed: https://skia.googlesource.com/skia/+/025b11ecde8733d9b3eee54e132cc50a5ce8eb78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -69 lines) Patch
M src/pathops/SkOpCoincidence.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 8 chunks +32 lines, -60 lines 0 comments Download
M src/pathops/SkOpSegment.h View 2 chunks +14 lines, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M src/pathops/SkOpSpan.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 4 chunks +9 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 5 chunks +79 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274803003/1
4 years, 3 months ago (2016-08-25 12:20:20 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:21:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/025b11ecde8733d9b3eee54e132cc50a5ce8eb78

Powered by Google App Engine
This is Rietveld 408576698