Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2274783002: Revert of [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo. (Closed)

Created:
4 years, 4 months ago by keishi
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blundell+watchlist_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, droger+watchlist_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jdonnelly+autofillwatch_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, rouslan+autofill_chromium.org, sdefresne+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo. (patchset #12 id:220001 of https://codereview.chromium.org/2216463002/ ) Reason for revert: Broke browser_test PasswordManagerBrowserTestBase.InternalsPage https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/7902/steps/browser_tests Original issue's description: > [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo. > > This CL > -Migrates all ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent > IPC messages into mojo interfaces. > -Revises related unit tests and browser tests. > > TEST=components_unittests, browser_tests > BUG=582391 > > Committed: https://crrev.com/38eab5aeedba6745c0d9f7d7c897c16982299d88 > Cr-Commit-Position: refs/heads/master@{#413708} TBR=rockot@chromium.org,mathp@chromium.org,sky@chromium.org,tsepez@chromium.org,vabr@chromium.org,yzshen@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582391 Committed: https://crrev.com/f4a12b8f7472dbd2646f571a4c0a02c3b23543fd Cr-Commit-Position: refs/heads/master@{#413934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -1110 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 6 chunks +12 lines, -70 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 4 chunks +17 lines, -15 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/autofill/fake_content_password_manager_driver.h View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/renderer/autofill/fake_content_password_manager_driver.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 28 chunks +159 lines, -143 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 9 chunks +32 lines, -48 lines 0 comments Download
M chrome/renderer/autofill/password_generation_test_utils.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/autofill/content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 4 chunks +4 lines, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/content/common/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M components/autofill/content/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/common/autofill_messages.h View 4 chunks +196 lines, -0 lines 0 comments Download
D components/autofill/content/public/cpp/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/content/public/interfaces/autofill_agent.mojom View 1 chunk +0 lines, -49 lines 0 comments Download
M components/autofill/content/public/interfaces/autofill_driver.mojom View 1 chunk +0 lines, -52 lines 0 comments Download
M components/autofill/content/renderer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.h View 6 chunks +9 lines, -21 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 17 chunks +45 lines, -54 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.h View 5 chunks +14 lines, -21 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 11 chunks +33 lines, -28 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger.h View 3 chunks +14 lines, -8 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc View 2 chunks +24 lines, -73 lines 0 comments Download
M components/autofill/content/renderer/test_password_generation_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/password_manager/content/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.h View 5 chunks +14 lines, -44 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 14 chunks +65 lines, -73 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.cc View 4 chunks +15 lines, -24 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_unittest.cc View 6 chunks +18 lines, -72 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.h View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
keishi
4 years, 4 months ago (2016-08-24 01:49:33 UTC) #2
Created Revert of [Autofill] Migrate
ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo.

Powered by Google App Engine
This is Rietveld 408576698