Add a --json option to git cl try-results.

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
@@ skipping 1832 matching lines @@
         ((['DoGetTrySlaves'], ), None),
         ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
     ]
     out = StringIO.StringIO()
     self.mock(git_cl.sys, 'stdout', out)
     self.assertEqual(0, git_cl.main(['try']))
     self.assertEqual(
         out.getvalue(),
         'scheduled CQ Dry Run on https://codereview.chromium.org/123\n')
 
+  def test_git_cl_try_results_json(self):
+    # out =
+    # self.mock(git_cl.sys, 'stdout', out)
+    self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda *_: 1)
+    self.calls = [
+        ((['git', 'symbolic-ref', 'HEAD'],), 'refs/heads/my-branch'),
+        ((['git', 'config', 'branch.my-branch.rietveldissue'],), '123'),
+        ((['git', 'config', 'rietveld.autoupdate'],), ''),
+        ((['git', 'config', 'rietveld.server'],),
+           'https://codereview.chromium.org'),
+        ((['git', 'config', 'branch.my-branch.rietveldpatchset'],), '1'),
+        ((['git', 'config', 'branch.my-branch.merge'],), 'feature'),
+        ((['git', 'config', 'branch.my-branch.remote'],), 'origin'),
+        (('write_json',
+          'output.json',
+          {'issue': 123,
+           'issue_url': 'https://codereview.chromium.org/123'}), '')
+    ]
+    pass

[iannucci, 2016/08/26 18:21:13]

this test doesn't look like it tests anything? It would be great if we could see
an example of the output JSON in this test.

[qyearsley, 2016/08/26 18:32:13]

Yeah, the test isn't written properly yet, I uploaded a patch before it was
finished :-/

+
   def _common_GerritCommitMsgHookCheck(self):
     self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
     self.mock(git_cl.os.path, 'abspath',
               lambda path: self._mocked_call(['abspath', path]))
     self.mock(git_cl.os.path, 'exists',
               lambda path: self._mocked_call(['exists', path]))
     self.mock(git_cl.gclient_utils, 'FileRead',
               lambda path: self._mocked_call(['FileRead', path]))
     self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
               lambda path: self._mocked_call(['rm_file_or_tree', path]))
@@ skipping 29 matching lines @@
         ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
          ''),
     ]
     cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
 
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()