Add a --json option to git cl try-results.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
@@ skipping 4739 matching lines @@
   group.add_option(
       "-p", "--patchset", type=int, help="patchset number if not current.")
   group.add_option(
       "--print-master", action='store_true', help="print master name as well.")
   group.add_option(
       "--color", action='store_true', default=setup_color.IS_TTY,
       help="force color output, useful when piping output.")
   group.add_option(
       "--buildbucket-host", default='cr-buildbucket.appspot.com',
       help="Host of buildbucket. The default host is %default.")
+  group.add_option(
+      "--json", action='store_true', default=False,

[tandrii(chromium), 2016/08/24 11:32:23]

no need for default.

[qyearsley, 2016/08/26 01:56:47]

Now changing this to be an option that takes a filename.

+      help="Output try job results as JSON instead of a human-readable format.")

[tandrii(chromium), 2016/08/24 11:32:23]

IMO, change to 'write try job results as JSON to a file' and change code
appropriately.


oh, wow, double quotes everywhere here :( keep as is, i'll clean it up once I
make it work for Gerrit.

[qyearsley, 2016/08/26 01:56:47]

Sounds good.

   parser.add_option_group(group)
   auth.add_auth_options(parser)
   options, args = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
 
   auth_config = auth.extract_auth_config_from_options(options)
   cl = Changelist(auth_config=auth_config)
   if not cl.GetIssue():
     parser.error('Need to upload first')
 
   if not options.patchset:
     options.patchset = cl.GetMostRecentPatchset()
     if options.patchset and options.patchset != cl.GetPatchset():
       print(
           '\nWARNING Mismatch between local config and server. Did a previous '
           'upload fail?\ngit-cl try always uses latest patchset from rietveld. '
           'Continuing using\npatchset %s.\n' % options.patchset)
   try:
     jobs = fetch_try_jobs(auth_config, cl, options)
   except BuildbucketResponseException as ex:
     print('Buildbucket error: %s' % ex)
     return 1
   except Exception as e:
     stacktrace = (''.join(traceback.format_stack()) + traceback.format_exc())
     print('ERROR: Exception when trying to fetch tryjobs: %s\n%s' %
           (e, stacktrace))
     return 1
-  print_tryjobs(options, jobs)
+  if options.json:
+    print(json.dumps(jobs, indent=2))

[tandrii(chromium), 2016/08/24 11:32:23]

hm, you want to dump the *whole* metadata? i don't really approve. This makes us
tied to buildbucket's current output. Can this instead be processed s.t. only
useful its are stored to json?

+nodir@/iannucci@ am I unreasonable?


and in any case, this warrants a test because machines will now rely on this.

+  else:
+    print_tryjobs(options, jobs)
   return 0
 
 
 @subcommand.usage('[new upstream branch]')
 def CMDupstream(parser, args):
   """Prints or sets the name of the upstream branch, if any."""
   _, args = parser.parse_args(args)
   if len(args) > 1:
     parser.error('Unrecognized args: %s' % ' '.join(args))
 
@@ skipping 419 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)