Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2274743002: Mojo C++ bindings: clean up pending callbacks when connection error occurs. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: clean up pending callbacks when connection error occurs. The callbacks may hold on to resources. There is no need to keep them after connection error occurs. They won't be called. BUG=640293 Committed: https://crrev.com/e462d5b92d10e8a14312683edc920ffbadacf43f Cr-Commit-Position: refs/heads/master@{#413890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-23 21:28:58 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-23 21:42:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274743002/1
4 years, 4 months ago (2016-08-23 21:45:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 23:20:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:23:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e462d5b92d10e8a14312683edc920ffbadacf43f
Cr-Commit-Position: refs/heads/master@{#413890}

Powered by Google App Engine
This is Rietveld 408576698