src/types.h - Issue 227473002: Use distinct maps for oddballs with special handling in the type system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.h

Issue 227473002: Use distinct maps for oddballs with special handling in the type system. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Get rid of the Oddball type. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/types.h

diff --git a/src/types.h b/src/types.h

index 0d172bdf0eb9bc64514bbb1fc7caf2f426dc0285..0149bdb6488e873548eb994d4a971fc68ebb1f99 100644

--- a/src/types.h

+++ b/src/types.h

@@ -24,7 +24,6 @@ namespace internal {

// None <= T

// T <= Any

-// Oddball = Boolean \/ Null \/ Undefined

// Number = Signed32 \/ Unsigned32 \/ Double

// Smi <= Signed32

// Name = String \/ Symbol

@@ -142,7 +141,6 @@ namespace internal {

V(Proxy, 1 << 15 | REPRESENTATION(kTaggedPtr)) \

V(Internal, 1 << 16 | REPRESENTATION(kTagged | kUntagged)) \

- V(Oddball, kBoolean | kNull | kUndefined) \

V(Signed32, kSignedSmall | kOtherSigned32) \

V(Number, kSigned32 | kUnsigned32 | kFloat) \

V(String, kInternalizedString | kOtherString) \

@@ -154,7 +152,8 @@ namespace internal {

V(Detectable, kDetectableReceiver | kNumber | kName) \

V(Object, kDetectableObject | kUndetectable) \

V(Receiver, kObject | kProxy) \

- V(NonNumber, kOddball | kName | kReceiver | kInternal) \

+ V(NonNumber, kBoolean | kInternal | kName | kNull | \

rossberg 2014/04/07 09:32:15 Nit: put kInternal last

Benedikt Meurer 2014/04/07 09:33:52 Done.

+ kReceiver | kUndefined) \

V(Any, kNumber | kNonNumber)

#define BITSET_TYPE_LIST(V) \

« no previous file with comments | « src/objects-debug.cc ('k') | src/types.cc » ('j') | no next file with comments »