Use distinct maps for oddballs with special handling in the type system.

Use distinct maps for oddballs with special handling in the type system.

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20531

[Benedikt Meurer, 2014-04-07 07:41:42]

As discussed offline last week... PTAL

[rossberg, 2014-04-07 09:04:03]

https://codereview.chromium.org/227473002/diff/1/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/227473002/diff/1/src/heap.h#newcode187
src/heap.h:187: V(Map, oddball_map, OddballMap)                                 
            \
Can't we have distinct maps for the other oddballs as well and get rid of this
entirely?

https://codereview.chromium.org/227473002/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/227473002/diff/1/src/types.cc#newcode181
src/types.cc:181: return kOddball;
I think you could now return kInternal here and eliminate the Oddball type.

[Benedikt Meurer, 2014-04-07 09:30:19]

https://codereview.chromium.org/227473002/diff/1/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/227473002/diff/1/src/heap.h#newcode187
src/heap.h:187: V(Map, oddball_map, OddballMap)                                 
            \
On 2014/04/07 09:04:03, rossberg wrote:
> Can't we have distinct maps for the other oddballs as well and get rid of this
> entirely?

Done.

https://codereview.chromium.org/227473002/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/227473002/diff/1/src/types.cc#newcode181
src/types.cc:181: return kOddball;
On 2014/04/07 09:04:03, rossberg wrote:
> I think you could now return kInternal here and eliminate the Oddball type.

Done.

[rossberg, 2014-04-07 09:32:15]

lgtm

https://codereview.chromium.org/227473002/diff/20008/src/types.h
File src/types.h (right):

https://codereview.chromium.org/227473002/diff/20008/src/types.h#newcode155
src/types.h:155: V(NonNumber,           kBoolean | kInternal | kName | kNull |  
      \
Nit: put kInternal last

[Benedikt Meurer, 2014-04-07 09:33:52]

https://codereview.chromium.org/227473002/diff/20008/src/types.h
File src/types.h (right):

https://codereview.chromium.org/227473002/diff/20008/src/types.h#newcode155
src/types.h:155: V(NonNumber,           kBoolean | kInternal | kName | kNull |  
      \
On 2014/04/07 09:32:15, rossberg wrote:
> Nit: put kInternal last

Done.

[Benedikt Meurer, 2014-04-07 09:41:24]

Committed patchset #5 manually as r20531 (presubmit successful).