Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp

Issue 2274723002: Fix one more integer overflow in ReadPageHintTable(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp
diff --git a/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp b/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp
index 18a7b8f0799c0297e487c6a4d617558be1a3887d..4363d3924c9054b7e502efc5ce8f93a1af84b2c2 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp
+++ b/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp
@@ -122,7 +122,7 @@ bool CPDF_HintTables::ReadPageHintTable(CFX_BitStream* hStream) {
// than enough to represent most of the values here.
constexpr uint32_t kMaxBits = 34;
if (dwSharedObjBits > kMaxBits || dwDeltaObjectsBits > kMaxBits ||
- dwSharedIdBits > kMaxBits) {
+ dwDeltaPageLenBits > kMaxBits || dwSharedIdBits > kMaxBits) {
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698