Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files which were/weren't producing the FOUC issue before.

Committed: https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef
Cr-Commit-Position: refs/heads/master@{#414645}

[oka, 2016-08-25 21:18:47]

Add a comment

[oka, 2016-08-25 21:22:57]

Description was changed from

==========
Fix FOUC issue on Quick View.

This is a workaround until the actual fix for webview lands.

BUG=640525
TEST=manually
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually
==========

[oka, 2016-08-25 21:22:57]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-25 21:25:47]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually by opening Quick View for audio, video and image, which were
producing the FOUC issue.
==========

[oka, 2016-08-25 21:27:42]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually by opening Quick View for audio, video and image, which were
producing the FOUC issue.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image, which
were producing the FOUC issue before.
==========

[oka, 2016-08-25 21:27:51]

PTAL.

[oka, 2016-08-25 21:28:29]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.

This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image, which
were producing the FOUC issue before.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image, which
were producing the FOUC issue before.
==========

[oka, 2016-08-25 21:29:02]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image, which
were producing the FOUC issue before.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were producing the FOUC issue before.
==========

[oka, 2016-08-25 21:32:35]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were producing the FOUC issue before.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were/weren't producing the FOUC issue before.
==========

[fukino, 2016-08-26 01:03:14]

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js
(right):

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js:40:
window.onresize = function() {
nit: window.addEventListener('resize'...  for consistency.

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js:45:
content.removeAttribute('hidden');
Could you add setTimeout or add tests to ensure that the fix for webview won't
break our function?

[oka, 2016-08-26 02:22:58]

Address comments

[oka, 2016-08-26 02:23:16]

PTAL.

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js
(right):

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js:40:
window.onresize = function() {
On 2016/08/26 01:03:14, fukino wrote:
> nit: window.addEventListener('resize'...  for consistency.

Done.

https://codereview.chromium.org/2274713006/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js:45:
content.removeAttribute('hidden');
On 2016/08/26 01:03:14, fukino wrote:
> Could you add setTimeout or add tests to ensure that the fix for webview won't
> break our function?

Done.

[fukino, 2016-08-26 02:26:32]

lgtm with a nit

https://codereview.chromium.org/2274713006/diff/60001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js
(right):

https://codereview.chromium.org/2274713006/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_safe_media_webview_content.js:47:
setTimeout(function() {
Please add a comment about the intention of this setTimeout().

[oka, 2016-08-26 02:31:53]

Fix.

[oka, 2016-08-26 02:32:07]

The CQ bit was checked by oka@chromium.org

[oka, 2016-08-26 02:32:08]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2274713006/#ps80001
(title: "Fix.")

[commit-bot: I haz the power, 2016-08-26 02:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 03:27:30]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were/weren't producing the FOUC issue before.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were/weren't producing the FOUC issue before.
==========

[commit-bot: I haz the power, 2016-08-26 03:27:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-26 03:32:35]

Description was changed from

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were/weren't producing the FOUC issue before.
==========

to

==========
Fix FOUC issue on Quick View.

Fix FOUC issue on Quick View by making img/audio/video initially be hidden and
removing hidden on the event of resize.
This is a workaround until the root cause is fixed.

BUG=640525
TEST=manually tested by opening Quick View for audio, video and image files
which were/weren't producing the FOUC issue before.

Committed: https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef
Cr-Commit-Position: refs/heads/master@{#414645}
==========

[commit-bot: I haz the power, 2016-08-26 03:32:36]

Patchset 5 (id:??) landed as
https://crrev.com/727463ca1bf5bba84683ab7f15bcfd101a5c46ef
Cr-Commit-Position: refs/heads/master@{#414645}