[MD settings] scroll to section from URL

[MD settings] scroll to section from URL

This CL moves the doWhenReady higher in the call chain to fix scrolling
to a section directly from an entered URL in the omnibox.

BUG=640102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cd5548a75759006cf54eaf13d662fc68e29ac33e
Cr-Commit-Position: refs/heads/master@{#414111}

[dschuyler, 2016-08-23 23:50:47]

Description was changed from

==========
[MD settings] scroll to section from URL

This CL moves the doWhenReady higher in the call chain to fix scrolling
to a section directly from an entered URL in the omnibox.

BUG=640102
==========

to

==========
[MD settings] scroll to section from URL

This CL moves the doWhenReady higher in the call chain to fix scrolling
to a section directly from an entered URL in the omnibox.

BUG=640102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-23 23:50:49]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 23:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-23 23:52:08]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-08-23 23:58:58]

lgtm

[commit-bot: I haz the power, 2016-08-24 01:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:24:02]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-08-24 18:25:34]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:26:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 18:34:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 18:35:58]

Description was changed from

==========
[MD settings] scroll to section from URL

This CL moves the doWhenReady higher in the call chain to fix scrolling
to a section directly from an entered URL in the omnibox.

BUG=640102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] scroll to section from URL

This CL moves the doWhenReady higher in the call chain to fix scrolling
to a section directly from an entered URL in the omnibox.

BUG=640102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cd5548a75759006cf54eaf13d662fc68e29ac33e
Cr-Commit-Position: refs/heads/master@{#414111}
==========

[commit-bot: I haz the power, 2016-08-24 18:35:59]

Patchset 1 (id:??) landed as
https://crrev.com/cd5548a75759006cf54eaf13d662fc68e29ac33e
Cr-Commit-Position: refs/heads/master@{#414111}

[michaelpg, 2016-08-24 22:01:59]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-08-24 22:02:00]

https://codereview.chromium.org/2274693003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2274693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:50:
doWhenReady(
can we change doWhenReady to run the callback immediately if the test is
initially true?

otherwise we are adding a 10ms delay to every transition for no reason, which
makes testing harder and the order things happen more confusing