Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2274683002: Don't skip column set interval tree search for flow thread offset == 0. (Closed)

Created:
4 years, 4 months ago by mstensho (USE GERRIT)
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't skip column set interval tree search for flow thread offset == 0. We cannot assume that offset 0 is in the first column set, since the first column set may be empty. Committed: https://crrev.com/8384519d410c668ddd779a7bb5fa2ce6289a2f7b Cr-Commit-Position: refs/heads/master@{#413939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/offset-properties-empty-content.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 4 months ago (2016-08-23 21:20:04 UTC) #6
eae
LGTM
4 years, 4 months ago (2016-08-23 22:22:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274683002/1
4 years, 4 months ago (2016-08-23 22:24:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 02:08:09 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 02:09:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8384519d410c668ddd779a7bb5fa2ce6289a2f7b
Cr-Commit-Position: refs/heads/master@{#413939}

Powered by Google App Engine
This is Rietveld 408576698