Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2274663004: Backing out change that removed legacy patch syntax (Closed)

Created:
4 years, 3 months ago by hausner
Modified:
4 years, 3 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse, Jacob, siva
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Backing out change that removed legacy patch syntax Dartium test html/async_spawnuri_test is failing when legacy patch class syntax parsing is removed. Once dartium is fixed, this change can be re-applied. TBR=terry Committed: https://github.com/dart-lang/sdk/commit/04b8a627d6020bcd41c022123797c2c3e1234d42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 7 chunks +48 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
hausner
4 years, 3 months ago (2016-08-24 23:48:22 UTC) #3
hausner
4 years, 3 months ago (2016-08-24 23:48:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04b8a627d6020bcd41c022123797c2c3e1234d42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698