Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2274643002: Assume all TURBO_HAS_* are true. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Assume all TURBO_HAS_* are true. Should be everyone's on libjpeg-turbo >= 1.5.0. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274643002 Committed: https://skia.googlesource.com/skia/+/da19f6f3b5f1375c854a9bde947c12099afc25c7

Patch Set 1 #

Patch Set 2 : reverse #

Total comments: 2

Patch Set 3 : drop RGB #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -85 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M public.bzl View 2 chunks +0 lines, -6 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 2 chunks +1 line, -12 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 2 8 chunks +6 lines, -56 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mtklein_C
4 years, 3 months ago (2016-08-23 18:08:31 UTC) #5
msarett
Beat me to it :) https://codereview.chromium.org/2274643002/diff/20001/src/codec/SkJpegCodec.cpp File src/codec/SkJpegCodec.cpp (right): https://codereview.chromium.org/2274643002/diff/20001/src/codec/SkJpegCodec.cpp#newcode567 src/codec/SkJpegCodec.cpp:567: if (JCS_CMYK == colorSpace ...
4 years, 3 months ago (2016-08-23 18:13:48 UTC) #6
mtklein_C
On 2016/08/23 at 18:13:48, msarett wrote: > Beat me to it :) > > https://codereview.chromium.org/2274643002/diff/20001/src/codec/SkJpegCodec.cpp ...
4 years, 3 months ago (2016-08-23 18:17:35 UTC) #8
msarett
lgtm
4 years, 3 months ago (2016-08-23 18:19:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274643002/40001
4 years, 3 months ago (2016-08-23 18:35:55 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 18:49:32 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/da19f6f3b5f1375c854a9bde947c12099afc25c7

Powered by Google App Engine
This is Rietveld 408576698