Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2274573007: Fix GetStackSample to check for nullptr (Closed)

Created:
4 years, 3 months ago by john.yan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GetStackSample to check for nullptr callback_entrypoint_address call could return nullptr and therefore causes seg fault intermittently. R=jochen@chromium.org, lpy@chromium.org, yangguo@chromium.org BUG= Committed: https://crrev.com/23a9405c592e07c6d29c4388b376526406ffc77d Cr-Commit-Position: refs/heads/master@{#38952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/profiler/tick-sample.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
john.yan
PTAL
4 years, 3 months ago (2016-08-25 17:24:05 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-26 15:09:55 UTC) #4
john.yan
On 2016/08/26 15:09:55, jochen wrote: > lgtm Thanks.
4 years, 3 months ago (2016-08-26 16:50:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274573007/1
4 years, 3 months ago (2016-08-26 16:51:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 17:16:15 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:17:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23a9405c592e07c6d29c4388b376526406ffc77d
Cr-Commit-Position: refs/heads/master@{#38952}

Powered by Google App Engine
This is Rietveld 408576698