Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2274403002: Replace two ASSERT()s for HashMap iterators with DCHECK_NE()s. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace two ASSERT()s for HashMap iterators with DCHECK_NE()s. These ASSERT()s compare HashMap iterators, and DCHECK*() requires stream printers for the iterators. This CL adds them. BUG=596760 Committed: https://crrev.com/9fb35e4705573752a8c348a3879885e560b5f93c Cr-Commit-Position: refs/heads/master@{#414383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M third_party/WebKit/Source/core/events/EventPath.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 5 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-25 06:32:28 UTC) #7
yosin_UTC9
lgtm nice!
4 years, 3 months ago (2016-08-25 06:45:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274403002/1
4 years, 3 months ago (2016-08-25 07:08:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 10:42:51 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 10:45:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb35e4705573752a8c348a3879885e560b5f93c
Cr-Commit-Position: refs/heads/master@{#414383}

Powered by Google App Engine
This is Rietveld 408576698