Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2274383002: Stop calling Platform::shutdown when a PPAPI/utility thread stop (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop calling Platform::shutdown when a PPAPI/utility thread stop As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion) and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), there is no reason we have to shut down the renderer gracefully. It's just causing use-after-free bugs and wasting performance. This CL stops calling Platform::shutdown() when a PPAPI/utility thread stop. BUG=639244 Committed: https://crrev.com/9953069136019c8fb2489763f925dc291d94c7c2 Cr-Commit-Position: refs/heads/master@{#415297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-25 01:42:16 UTC) #3
haraken
jam@: friendly ping?
4 years, 3 months ago (2016-08-26 00:55:07 UTC) #7
haraken
Elliott: Would you take a look at this?
4 years, 3 months ago (2016-08-27 00:36:53 UTC) #9
esprehn
lgtm
4 years, 3 months ago (2016-08-27 01:21:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274383002/1
4 years, 3 months ago (2016-08-27 01:23:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/247685)
4 years, 3 months ago (2016-08-27 01:29:42 UTC) #14
haraken
jam@: Would you take a look as an owner?
4 years, 3 months ago (2016-08-29 15:29:50 UTC) #15
haraken
jochen@: Would you take a look at this?
4 years, 3 months ago (2016-08-30 03:32:22 UTC) #17
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-30 11:51:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274383002/1
4 years, 3 months ago (2016-08-30 14:14:43 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 15:08:14 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 15:09:46 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9953069136019c8fb2489763f925dc291d94c7c2
Cr-Commit-Position: refs/heads/master@{#415297}

Powered by Google App Engine
This is Rietveld 408576698