Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2274373003: SkDrawCommand: hinting (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : compare against SkPaintDefaults_Hinting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M tools/debugger/SkDrawCommand.cpp View 1 6 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hal.canary
Is this right?
4 years, 3 months ago (2016-08-25 17:07:28 UTC) #5
ethannicholas
On 2016/08/25 17:07:28, Hal Canary wrote: > Is this right? lgtm
4 years, 3 months ago (2016-08-25 17:39:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274373003/20001
4 years, 3 months ago (2016-08-25 17:42:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot/builds/880)
4 years, 3 months ago (2016-08-25 17:44:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274373003/20001
4 years, 3 months ago (2016-08-25 18:00:00 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:10:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f412f0988424cb5fad48a6097c8b29b5b9c56275

Powered by Google App Engine
This is Rietveld 408576698