Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2274373002: Hook up the Background Loader to StartDownload for offline pages. (Closed)

Created:
4 years, 4 months ago by Dmitry Titov
Modified:
4 years, 3 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up the Background Loader to StartDownload for offline pages. If the page in the tab is not ready to be captured right from the tab, we will post a background loader request and exit. The page will be loaded when conditions permit. BUG=630817 Committed: https://crrev.com/14ba6e1ac8051f481d2bc42b2750d0cb2b5968bd Cr-Commit-Position: refs/heads/master@{#414526}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 2 chunks +27 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Dmitry Titov
4 years, 4 months ago (2016-08-25 01:25:51 UTC) #2
Pete Williamson
LGTM with nit https://codereview.chromium.org/2274373002/diff/1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc File chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc (right): https://codereview.chromium.org/2274373002/diff/1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc#newcode160 chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:160: // If the page is not ...
4 years, 4 months ago (2016-08-25 01:33:54 UTC) #3
Dmitry Titov
https://codereview.chromium.org/2274373002/diff/1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc File chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc (right): https://codereview.chromium.org/2274373002/diff/1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc#newcode160 chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:160: // If the page is not loaded enough to ...
4 years, 4 months ago (2016-08-25 02:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274373002/20001
4 years, 3 months ago (2016-08-25 19:41:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 20:27:38 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 20:31:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14ba6e1ac8051f481d2bc42b2750d0cb2b5968bd
Cr-Commit-Position: refs/heads/master@{#414526}

Powered by Google App Engine
This is Rietveld 408576698