gyp/common_conditions.gypi - Issue 227433009: Rename kPMColor_SkColorType to kN32_SkColorType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/common_conditions.gypi

Issue 227433009: Rename kPMColor_SkColorType to kN32_SkColorType. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rename kPMColor_SkColorType inside Skia. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/common_conditions.gypi

diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi

index 3743b60d3c089750fb6aaeba330da3f364199109..92fb819f08e37c74b30e06a7de8941032b8edd17 100644

--- a/gyp/common_conditions.gypi

+++ b/gyp/common_conditions.gypi

@@ -301,9 +301,8 @@

# Temporary until https:#googleplex-android-review.git.corp.google.com/#/c/442220/

# lands.

'SK_SUPPORT_LEGACY_GETTOTALCLIP',

- # Use a better name for kPMColor_SkColorType until

- # https://code.google.com/p/skia/issues/detail?id=2384 is fixed.

- 'kNative_8888_SkColorType kPMColor_SkColorType',

+ # Still need to switch Android to the new name for N32.

+ 'kNative_8888_SkColorType kN32_SkColorType',

scroggo 2014/04/08 19:38:10 On Android I used kNative_8888, but I can switch t

}],

« no previous file with comments | « gm/tilemodes_scaled.cpp ('k') | gyp/skia_for_chromium_defines.gypi » ('j') | no next file with comments »