Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 227433006: Remove CreatePlatformFile from file_util_proxy (Closed)

Created:
6 years, 8 months ago by rvargas (doing something else)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove CreatePlatformFile from file_util_proxy Most of file_util_proxy is going to be deleted soon (users have to migrate to FileProxy) so this CL is quite superficial. It is intended to remove the last uses of CreatePlatformFile so that the method can be removed and no new code can ignore base::File. BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M base/files/file_util_proxy.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rvargas (doing something else)
PTAL
6 years, 8 months ago (2014-04-07 23:27:51 UTC) #1
willchan no longer on Chromium
lgtm
6 years, 8 months ago (2014-04-08 17:45:27 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 8 months ago (2014-04-08 23:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/227433006/1
6 years, 8 months ago (2014-04-08 23:11:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 23:44:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-08 23:44:03 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 8 months ago (2014-04-09 15:31:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/227433006/1
6 years, 8 months ago (2014-04-09 15:31:44 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 19:58:59 UTC) #9
Message was sent while issue was closed.
Change committed as 262781

Powered by Google App Engine
This is Rietveld 408576698