Add runtime and native entry tags

runtime/vm/tags.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_TAGS_H_
 #define VM_TAGS_H_
 
 #include "vm/allocation.h"
 
 namespace dart {
 
 class Isolate;
 class JSONObject;
 
+// The list below must be manually kept in sync with the VM sources.
+#define RUNTIME_ENTRY_TAG_LIST(V)                                              \
+  V(AllocateArray)                                                             \
+  V(AllocateContext)                                                           \
+  V(AllocateObject)                                                            \
+  V(BreakpointRuntimeHandler)                                                  \
+  V(SingleStepHandler)                                                         \
+  V(CloneContext)                                                              \
+  V(FixCallersTarget)                                                          \
+  V(InlineCacheMissHandlerOneArg)                                              \
+  V(InlineCacheMissHandlerTwoArgs)                                             \
+  V(InlineCacheMissHandlerThreeArgs)                                           \
+  V(StaticCallMissHandlerTwoArgs)                                              \
+  V(Instanceof)                                                                \
+  V(TypeCheck)                                                                 \
+  V(BadTypeError)                                                              \
+  V(NonBoolTypeError)                                                          \
+  V(InstantiateType)                                                           \
+  V(InstantiateTypeArguments)                                                  \
+  V(InvokeNoSuchMethodFunction)                                                \
+  V(MegamorphicCacheMissHandler)                                               \
+  V(OptimizeInvokedFunction)                                                   \
+  V(TraceICCall)                                                               \
+  V(PatchStaticCall)                                                           \
+  V(InvokeNonClosure)                                                          \
+  V(ReThrow)                                                                   \
+  V(StackOverflow)                                                             \
+  V(Throw)                                                                     \
+  V(TraceFunctionEntry)                                                        \
+  V(TraceFunctionExit)                                                         \
+  V(DeoptimizeMaterialize)                                                     \
+  V(UpdateFieldCid)                                                            \
+  V(CompileFunction)                                                           \

[siva, 2014/04/08 16:27:54]

Can this be made part of DEFINE_RUNTIME_ENTRY i.e the DEFINE_RUNTIME_ENTRY fills
up the table that you want for looking up runtime entries.

[Cutch, 2014/04/09 17:40:59]

DEFINE_RUNTIME_ENTRY cannot execute code so I'm not sure how I could dynamically
register runtime entries in the macro.

[siva, 2014/04/09 23:28:11]

Look at UNIT_TEST_CASE in unit_test.h it creates a static const object and the
constructor of that object runs linking each test case into a list. This list is
then traversed later, we could do something similar to set up a list of runtime
entries which you can then traverse.


On 2014/04/09 17:40:59, Cutch wrote:

[Cutch, 2014/04/10 15:30:27]

Done.

+
+
 #define VM_TAG_LIST(V)                                                         \
   V(Idle)                                                                      \
   V(VM) /* Catch all */                                                        \
   V(Compile)                                                                   \
   V(Script)                                                                    \
   V(GCNewSpace)                                                                \
   V(GCOldSpace)                                                                \
-  V(RuntimeNative)                                                             \
+  V(Runtime)                                                                   \
+  V(Native)                                                                    \
 
 
 class VMTag : public AllStatic {
  public:
   enum VMTagId {
     kInvalidTagId = 0,
 #define DEFINE_VM_TAG_ID(tag)                                                  \
     k##tag##TagId,
     VM_TAG_LIST(DEFINE_VM_TAG_ID)
 #undef DEFINE_VM_TAG_KIND
     kNumVMTags,
   };
 
   static const char* TagName(uword id);
+  static bool IsNativeEntryTag(uword id);
+
+  static bool IsRuntimeEntryTag(uword id);
+  static const char* RuntimeEntryTagName(uword id);
 
  private:
   struct TagEntry {
     const char* name;
     uword id;
   };
   static TagEntry entries_[];
 };
 
 
@@ skipping 19 matching lines @@
 
   void PrintToJSONObject(JSONObject* obj);
 
  private:
   int64_t counters_[VMTag::kNumVMTags];
 };
 
 }  // namespace dart
 
 #endif  // VM_TAGS_H_