blimp/client/app/linux/blimp_display_manager.h - Issue 2274323002: Expose Blimp dependencies to the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/linux/blimp_display_manager.h

Issue 2274323002: Expose Blimp dependencies to the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@khushal_baseline_1

Patch Set: Addressed Khushal's initial comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/app/compositor/browser_compositor.cc ('K') | « blimp/client/app/compositor/browser_compositor.cc ('k') | blimp/client/app/linux/blimp_display_manager.cc » ('j') | blimp/client/core/compositor/blimp_compositor_dependencies.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/linux/blimp_display_manager.h

diff --git a/blimp/client/app/linux/blimp_display_manager.h b/blimp/client/app/linux/blimp_display_manager.h

index b379f6f24fddbf04c3cf5bcee08a5512569a8c67..e626765b004b23e200a9327ccc2368338299320b 100644

--- a/blimp/client/app/linux/blimp_display_manager.h

+++ b/blimp/client/app/linux/blimp_display_manager.h

@@ -58,9 +58,9 @@ class BlimpDisplayManager : public ui::PlatformWindowDelegate {

BlimpDisplayManagerDelegate* delegate_;

TabControlFeature* tab_control_feature_;

+ std::unique_ptr<BlimpCompositorDependencies> compositor_dependencies_;

+ std::unique_ptr<BlimpCompositorManager> compositor_manager_;

std::unique_ptr<BrowserCompositor> compositor_;

- std::unique_ptr<BlimpCompositorManager> blimp_compositor_manager_;

std::unique_ptr<ui::PlatformWindow> platform_window_;

DISALLOW_COPY_AND_ASSIGN(BlimpDisplayManager);