Convert OneClickSigninBubbleViewTest to browser_tests.

chrome/browser/ui/views/sync/one_click_signin_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_SYNC_ONE_CLICK_SIGNIN_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_SYNC_ONE_CLICK_SIGNIN_BUBBLE_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 35 matching lines @@
                          const BrowserWindow::StartSyncCallback& start_sync);
 
   static bool IsShowing();
 
   static void Hide();
 
   // Gets the global bubble view.  If its not showing returns NULL.  This
   // method is meant to be called only from tests.
   static OneClickSigninBubbleView* view_for_testing() { return bubble_view_; }
 
+  // We normally close the bubble any time it becomes inactive but this can lead
+  // to flaky tests where unexpected UI events are triggering this behavior.
+  // Tests should call this with "false" for more consistent operation.
+  // (crbug.com/266972)
+  static void set_close_on_deactivate_for_testing(bool close) {

[fdoray, 2013/08/09 18:22:42]

The method is not called set_close_on_deactivate() because I don't want to
override BubbleDelegateView::set_close_on_deactivate.

This is an issue in AvatarMenuBubbleView and ProfileChooserView
crbug.com/270888.

+    close_on_deactivate_ = close;
+  }
+
  protected:
   // Creates a OneClickSigninBubbleView.
   OneClickSigninBubbleView(
       const string16& error_message,
       const string16& email,
       scoped_ptr<OneClickSigninBubbleDelegate> delegate,
       views::View* anchor_view,
       const BrowserWindow::StartSyncCallback& start_sync_callback,
       bool is_sync_dialog);
 
@@ skipping 75 matching lines @@
   views::ImageButton* close_button_;
 
   bool clicked_learn_more_;
 
   // A message loop used only with unit tests.
   base::MessageLoop* message_loop_for_testing_;
 
   // The bubble, if we're showing one.
   static OneClickSigninBubbleView* bubble_view_;
 
+  static bool close_on_deactivate_;

[Roger Tawa OOO till Jul 10th, 2013/08/09 18:55:10]

Better to rename this variable so its not the same as the base class member. 
Maybe |close_on_deactivate_for_testing_| ?

+
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_SYNC_ONE_CLICK_SIGNIN_BUBBLE_VIEW_H_