Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2274283003: Use mojo.common.mojom.Time for dispatch_event_time in background_sync.mojom (Closed)

Created:
4 years, 3 months ago by horo
Modified:
4 years, 3 months ago
Reviewers:
dcheng, iclelland
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, iclelland+watch_chromium.org, viettrungluu+watch_chromium.org, jam, chasej+watch_chromium.org, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, jkarlin+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, nhiroki, michaeln, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review), Marijn Kruisselbrink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mojo.common.mojom.Time for dispatch_event_time in background_sync.mojom BUG=561209 Committed: https://crrev.com/f3310340da7d8027e56cf88b90fe4d8622db9144 Cr-Commit-Position: refs/heads/master@{#418467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M content/browser/background_sync/background_sync_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
horo
dcheng@ Could you please review this?
4 years, 3 months ago (2016-08-25 10:57:38 UTC) #4
dcheng
LGTM, sorry for missing this CL
4 years, 3 months ago (2016-09-08 19:34:59 UTC) #7
horo
iclelland@ Please review content/browser/background_sync/*.
4 years, 3 months ago (2016-09-12 02:10:33 UTC) #9
iclelland
On 2016/09/12 02:10:33, horo wrote: > iclelland@ > Please review content/browser/background_sync/*. background_sync LGTM, thanks! nit: ...
4 years, 3 months ago (2016-09-13 18:45:16 UTC) #10
horo
On 2016/09/13 18:45:16, iclelland wrote: > On 2016/09/12 02:10:33, horo wrote: > > iclelland@ > ...
4 years, 3 months ago (2016-09-14 00:42:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274283003/1
4 years, 3 months ago (2016-09-14 00:43:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 03:04:30 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:05:56 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3310340da7d8027e56cf88b90fe4d8622db9144
Cr-Commit-Position: refs/heads/master@{#418467}

Powered by Google App Engine
This is Rietveld 408576698