Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2274253003: [compiler] Don't canonicalize handles in Crankshaft. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Don't canonicalize handles in Crankshaft. R=mstarzinger@chromium.org BUG=v8:5309 Committed: https://crrev.com/b550c07734674f5757be4c1060cf0e30a69e7928 Cr-Commit-Position: refs/heads/master@{#38903}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move handle scopes into GetOptimizedCode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/compiler.cc View 1 6 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-25 10:41:29 UTC) #1
Benedikt Meurer
Michi: PTAL Toon: FYI
4 years, 4 months ago (2016-08-25 11:17:31 UTC) #8
Michael Starzinger
https://codereview.chromium.org/2274253003/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/2274253003/diff/1/src/compiler.cc#newcode726 src/compiler.cc:726: CompilationHandleScope handle_scope(info); Would it be possible to hoist both, ...
4 years, 4 months ago (2016-08-25 11:44:20 UTC) #9
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-25 11:44:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274253003/20001
4 years, 4 months ago (2016-08-25 11:54:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-25 11:56:18 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 11:56:38 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b550c07734674f5757be4c1060cf0e30a69e7928
Cr-Commit-Position: refs/heads/master@{#38903}

Powered by Google App Engine
This is Rietveld 408576698